feat(type): improve the Fields derive macro
#14934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Runji Wang <[email protected]>
wangrunji0408
changed the title
Fields derive macroFields derive macro
Signed-off-by: Runji Wang <[email protected]>
BugenZhao
reviewed
Feb 2, 2024
| @@ -570,10 +570,17 @@ pub trait ToOwnedDatum { | |||
| fn to_owned_datum(self) -> Datum; | |||
| } | |||
|
|
|||
| impl ToOwnedDatum for DatumRef<'_> { | |||
| impl<T: Into<ScalarImpl>> ToOwnedDatum for T { | |||
There was a problem hiding this comment.
TBH I'd prefer introducing a new trait for doing such conversion. By ToOwnedDatum I suppose it's only for the conversion from the ref type to an owned type, just like the std's ToOwned trait with GAT support.
There was a problem hiding this comment.
But logically types impl Into<ScalarImpl> can be converted ToOwnedDatum. I think it would be convenient to reuse this trait.
9 tasks
Signed-off-by: Runji Wang <[email protected]>
Signed-off-by: Runji Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
This PR adds
primary_keyandinto_owned_rowsupport to theFieldstrait and derive macro.This is a preparation for refactoring system catalogs #13433.
Checklist
./risedev check(or alias,./risedev c)Documentation